This is an automated email from the ASF dual-hosted git repository.

asdf2014 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new cf9bc507f6a Fix compilation failure due to missing constant 
MISSING_JOIN_CONVERSION (#16050)
cf9bc507f6a is described below

commit cf9bc507f6a3f0e5b3adc776d7d01686f8d7e6c7
Author: Vishesh Garg <[email protected]>
AuthorDate: Wed Mar 6 13:04:39 2024 +0530

    Fix compilation failure due to missing constant MISSING_JOIN_CONVERSION 
(#16050)
    
    * Reintroduce variable MISSING_JOIN_CONVERSION
    
    * Remove redundant constant MISSING_JOIN_CONVERSION2
    
    * Correct fix to address failing tests
---
 sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java | 3 +--
 sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java  | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java 
b/sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
index 0a3cd0c7a54..e7cfdc6e4b0 100644
--- a/sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
+++ b/sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
@@ -15307,7 +15307,6 @@ public class CalciteQueryTest extends 
BaseCalciteQueryTest
         .run();
   }
 
-  @NotYetSupported(Modes.MISSING_JOIN_CONVERSION)
   @Test
   public void testScanAndSortOnJoin()
   {
@@ -15340,7 +15339,7 @@ public class CalciteQueryTest extends 
BaseCalciteQueryTest
         .run();
   }
 
-  @NotYetSupported(Modes.MISSING_JOIN_CONVERSION)
+  @NotYetSupported(Modes.WINDOW_OPERATOR_QUERY_ON_UNSUPPORTED_DATASOURCE)
   @Test
   public void testWindowingOverJoin()
   {
diff --git 
a/sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java 
b/sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java
index 4fe39234fad..358d44267dc 100644
--- a/sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java
+++ b/sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java
@@ -93,6 +93,7 @@ public @interface NotYetSupported
     T_ALLTYPES_ISSUES(AssertionError.class, 
"(t_alltype|allTypsUniq|fewRowsAllData).parquet.*Verifier.verify"),
     RESULT_MISMATCH(AssertionError.class, "(assertResulEquals|AssertionError: 
column content mismatch)"),
     UNSUPPORTED_NULL_ORDERING(DruidException.class, "(A|DE)SCENDING ordering 
with NULLS (LAST|FIRST)"),
+    WINDOW_OPERATOR_QUERY_ON_UNSUPPORTED_DATASOURCE(DruidException.class, 
"WindowOperatorQuery must run on top of a query or inline data source"),
     UNION_WITH_COMPLEX_OPERAND(DruidException.class, "Only Table and Values 
are supported as inputs for Union"),
     UNION_MORE_STRICT_ROWTYPE_CHECK(DruidException.class, "Row signature 
mismatch in Union inputs"),
     JOIN_CONDITION_NOT_PUSHED_CONDITION(DruidException.class, "SQL requires a 
join with '.*' condition"),


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to