soumyava commented on code in PR #16033:
URL: https://github.com/apache/druid/pull/16033#discussion_r1514757469
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchSqlAggregatorTest.java:
##########
@@ -1318,6 +1320,20 @@ public void testFloatAndDoubleAreConsideredTheSame()
);
}
+ @Test
+ public void testDsHllOnTopOfNested()
+ {
+ // this query was not planable:
https://github.com/apache/druid/issues/15353
+ testBuilder()
+ .queryContext(ImmutableMap.of(QueryContexts.ENABLE_DEBUG, true))
Review Comment:
Probably just use QUERY_CONTEXT_DEFAULT here and not introduce debug mode
for a test case
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchSqlAggregatorTest.java:
##########
@@ -1318,6 +1320,20 @@ public void testFloatAndDoubleAreConsideredTheSame()
);
}
+ @Test
+ public void testDsHllOnTopOfNested()
+ {
+ // this query was not planable:
https://github.com/apache/druid/issues/15353
+ testBuilder()
+ .queryContext(ImmutableMap.of(QueryContexts.ENABLE_DEBUG, true))
+ .sql(
+ "SELECT d1,dim2,APPROX_COUNT_DISTINCT_DS_HLL(dim2, 18) as val"
+ + " FROM (select d1,dim1,dim2 from druid.foo group by
d1,dim1,dim2 order by dim1 limit 3) t "
+ + " group by 1,2"
+ )
+ .run();
Review Comment:
We should add the expected results of this query as well to make sure the
results do not change later down the line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
