gianm opened a new pull request, #16073:
URL: https://github.com/apache/druid/pull/16073
This patch adds an EngineFeature "GROUPBY_IMPLICITLY_SORTS" and sets it true
for native, false for MSQ. It's useful for two reasons:
1) In the future we'll likely want MSQ to hash-partition for GROUP BY
instead of using a global sort, which would mean MSQ would not
implicitly ORDER BY when there is a GROUP BY.
2) When doing REPLACE with MSQ, CLUSTERED BY is transformed to ORDER BY.
We should retain that ORDER BY, as it may be a subset of the GROUP BY,
and it is important to remember which fields the user wanted to include in
range shard specs.
Due to (2), this patch fixes an issue where sometimes the `CLUSTERED BY`
would be "forgotten". The new test case
`testReplaceOnFoo1RangeClusteredBySubset` fails without the rest of the patch
being applied, because `NumberedShardSpec` is used instead of
`DimensionRangeShardSpec`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
