gzhao9 commented on PR #15980: URL: https://github.com/apache/druid/pull/15980#issuecomment-1984740443
> > Thanks for taking out the time. I donot see value in this refactor. This adds another layer which is used in a single testClass. > > Thank you for your feedback. I've removed `CreateMockColumnValueSelector` and added its creat mock function directly into the test classes as suggested. Could you please share your preferences for preparing mock object data in tests? Or any suggestions you wish to change? I'd like to clarify. When I first submitted my PR, the class was used by 3 test classes, not a single test class. So I'm a little confused about `This adds another layer which is used in a single testClass.`. If you mean to avoid creating a new class. my modification is to create a method in each test class. In the test case, the method is called to minimize the duplicate creation of mock objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
