This is an automated email from the ASF dual-hosted git repository.
abhishekrb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 8084f2206b0 Remove `@JsonIgnore` annotations for private members of
`TaskAction` classes (#16099)
8084f2206b0 is described below
commit 8084f2206b0f4c16b4ca1017e3e6e2a98381a7b2
Author: Abhishek Radhakrishnan <[email protected]>
AuthorDate: Tue Mar 12 02:42:36 2024 +0800
Remove `@JsonIgnore` annotations for private members of `TaskAction`
classes (#16099)
* Remove @JsonIgnore annotations for private members
* checkstyle fix - removed unused imports.
---
.../apache/druid/indexing/common/actions/LockReleaseAction.java | 2 --
.../druid/indexing/common/actions/MarkSegmentsAsUnusedAction.java | 4 ----
.../indexing/common/actions/RetrieveUnusedSegmentsAction.java | 8 --------
.../druid/indexing/common/actions/RetrieveUsedSegmentsAction.java | 6 ------
.../indexing/common/actions/SegmentMetadataUpdateAction.java | 2 --
.../apache/druid/indexing/common/actions/SegmentNukeAction.java | 2 --
.../druid/indexing/common/actions/TimeChunkLockAcquireAction.java | 5 -----
.../indexing/common/actions/TimeChunkLockTryAcquireAction.java | 4 ----
.../druid/indexing/common/actions/UpdateLocationAction.java | 2 --
.../apache/druid/indexing/common/actions/UpdateStatusAction.java | 3 ---
10 files changed, 38 deletions(-)
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/LockReleaseAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/LockReleaseAction.java
index 12e4ba16322..fa8e1d6bea2 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/LockReleaseAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/LockReleaseAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import org.apache.druid.indexing.common.task.Task;
@@ -28,7 +27,6 @@ import org.joda.time.Interval;
public class LockReleaseAction implements TaskAction<Void>
{
- @JsonIgnore
private final Interval interval;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/MarkSegmentsAsUnusedAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/MarkSegmentsAsUnusedAction.java
index 5ed7b7e99be..ddf57afbc18 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/MarkSegmentsAsUnusedAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/MarkSegmentsAsUnusedAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import org.apache.druid.indexing.common.task.Task;
@@ -28,10 +27,7 @@ import org.joda.time.Interval;
public class MarkSegmentsAsUnusedAction implements TaskAction<Integer>
{
- @JsonIgnore
private final String dataSource;
-
- @JsonIgnore
private final Interval interval;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java
index bb188952966..8b474153e18 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import org.apache.druid.indexing.common.task.Task;
@@ -34,16 +33,9 @@ import java.util.List;
public class RetrieveUnusedSegmentsAction implements
TaskAction<List<DataSegment>>
{
- @JsonIgnore
private final String dataSource;
-
- @JsonIgnore
private final Interval interval;
-
- @JsonIgnore
private final Integer limit;
-
- @JsonIgnore
private final DateTime maxUsedStatusLastUpdatedTime;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUsedSegmentsAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUsedSegmentsAction.java
index 29986eeba55..4e5f134c521 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUsedSegmentsAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUsedSegmentsAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import com.google.common.base.Preconditions;
@@ -67,13 +66,8 @@ public class RetrieveUsedSegmentsAction implements
TaskAction<Collection<DataSeg
{
private static final Logger log = new
Logger(RetrieveUsedSegmentsAction.class);
- @JsonIgnore
private final String dataSource;
-
- @JsonIgnore
private final List<Interval> intervals;
-
- @JsonIgnore
private final Segments visibility;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentMetadataUpdateAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentMetadataUpdateAction.java
index 9c90cf0efaa..cbad8bfcc5c 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentMetadataUpdateAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentMetadataUpdateAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import com.google.common.collect.ImmutableSet;
@@ -38,7 +37,6 @@ import java.util.stream.Collectors;
public class SegmentMetadataUpdateAction implements TaskAction<Void>
{
- @JsonIgnore
private final Set<DataSegment> segments;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentNukeAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentNukeAction.java
index ec7218eae59..2856f161e0e 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentNukeAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentNukeAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import com.google.common.collect.ImmutableSet;
@@ -38,7 +37,6 @@ import java.util.stream.Collectors;
public class SegmentNukeAction implements TaskAction<Void>
{
- @JsonIgnore
private final Set<DataSegment> segments;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockAcquireAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockAcquireAction.java
index e6a11f8f491..305a0d7b284 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockAcquireAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockAcquireAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import com.google.common.base.Preconditions;
@@ -41,11 +40,7 @@ import javax.annotation.Nullable;
public class TimeChunkLockAcquireAction implements TaskAction<TaskLock>
{
private final TaskLockType type;
-
- @JsonIgnore
private final Interval interval;
-
- @JsonIgnore
private final long timeoutMs;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockTryAcquireAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockTryAcquireAction.java
index f1379141ba7..07bcfa5c101 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockTryAcquireAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockTryAcquireAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import org.apache.druid.indexing.common.TaskLock;
@@ -38,10 +37,7 @@ import javax.annotation.Nullable;
*/
public class TimeChunkLockTryAcquireAction implements TaskAction<TaskLock>
{
- @JsonIgnore
private final TaskLockType type;
-
- @JsonIgnore
private final Interval interval;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateLocationAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateLocationAction.java
index f4926864dcb..dce9f00c35b 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateLocationAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateLocationAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import com.google.common.base.Optional;
@@ -30,7 +29,6 @@ import org.apache.druid.indexing.overlord.TaskRunner;
public class UpdateLocationAction implements TaskAction<Void>
{
- @JsonIgnore
private final TaskLocation taskLocation;
@JsonCreator
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateStatusAction.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateStatusAction.java
index 0f1fd445c6e..2ff8375b7f6 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateStatusAction.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateStatusAction.java
@@ -20,7 +20,6 @@
package org.apache.druid.indexing.common.actions;
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.core.type.TypeReference;
import com.google.common.base.Optional;
@@ -32,9 +31,7 @@ import java.util.Objects;
public class UpdateStatusAction implements TaskAction<Void>
{
- @JsonIgnore
private final String status;
- @JsonIgnore
private final TaskStatus statusFull;
@Deprecated
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
