soumyava commented on code in PR #16063:
URL: https://github.com/apache/druid/pull/16063#discussion_r1520252343
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:
##########
@@ -136,6 +136,24 @@ public void validateWindow(SqlNode windowOrId,
SqlValidatorScope scope, @Nullabl
);
}
+ boolean hasBounds = lowerBound != null || upperBound != null;
Review Comment:
Can we add a negative test in the description to indicate what kind of
queries are we restricting so that the user can get an idea. Also good
candidate to indicate in the docs as well as NTILE does not support framing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
