cryptoe opened a new pull request, #16107:
URL: https://github.com/apache/druid/pull/16107

   With #15880  going in, it exposed a potential data race where the MSQ 
controller would post finish to the workers but still fetch the results from 
them. 
   The change pushes the result fetching before we issue a worker finish. 
   As a result of this change, now we would materialize all the rows of the 
select result in the controller memory. This is okay when 
`selectDestination=durableStorage` but a little problematic when 
`selectDestination=taskReport` since the former has a limit of 3000 rows but 
the later can go wild. 
   
   The other way would be to hold of finishing the tasks till we write out the 
task report. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to