abhishekrb19 commented on PR #16127: URL: https://github.com/apache/druid/pull/16127#issuecomment-1998677367
Good catch 👍 It's also probably worth mentioning in the PR description that this bug exists only when users are marking segments as used by interval or by segment ids for a datasource that contains no used segments. In other words, users can still recover a datasource by marking _all_ segments as used, via `markAsUsedAllNonOvershadowedSegments`, which [doesn't](https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java#L200C12-L200C32) have the short circuit logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
