clintropolis commented on code in PR #16128:
URL: https://github.com/apache/druid/pull/16128#discussion_r1525705175
##########
processing/src/main/java/org/apache/druid/math/expr/vector/VectorMathProcessors.java:
##########
@@ -47,13 +47,12 @@ public static <T> ExprVectorProcessor<T> makeMathProcessor(
final ExpressionType inputType = arg.getOutputType(inspector);
ExprVectorProcessor<?> processor = null;
- if (inputType != null) {
- if (inputType.is(ExprType.LONG)) {
- processor = longOutLongInSupplier.get();
- } else if (inputType.is(ExprType.DOUBLE)) {
- processor = doubleOutDoubleInSupplier.get();
- }
+ if (inputType == null || inputType.is(ExprType.DOUBLE)) {
Review Comment:
nit: use `Types.isNullOr(inputType, ExprType.DOUBLE)`, same for other lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
