kgyrtkirk commented on PR #16106: URL: https://github.com/apache/druid/pull/16106#issuecomment-2004325782
> > UnnecessaryThrows > How was this resolved? I don't see it failing anymore. I've removed the global enablement of `UnnecessaryThrows` ; we can do that later - I was over-zealous adding it right next to pushing the branch - it did not fail on the few modules I was checking :) > > there is something with the CalciteSelectJoinQueryMSQTest ; it did run locally for me - but not by the CI. > Did it help? my investigation have lead to uncover that `Surefire` has that [odd exclusion setting](https://github.com/junit-team/junit5/issues/1377) - removing all `@RunWith(Nested.class)` and disabling the exclusion should be much better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
