findingrish commented on code in PR #15817:
URL: https://github.com/apache/druid/pull/15817#discussion_r1529964957
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -2245,29 +2376,41 @@ private void insertIntoUpgradeSegmentsTable(
}
}
- private List<DataSegment> retrieveSegmentsById(Handle handle, String
datasource, Set<String> segmentIds)
+ private List<DataSegmentWithSchemaInformation> retrieveSegmentsById(Handle
handle, String datasource, Set<String> segmentIds)
{
if (segmentIds.isEmpty()) {
return Collections.emptyList();
}
return SqlSegmentsMetadataQuery.forHandle(handle, connector, dbTables,
jsonMapper)
- .retrieveSegmentsById(datasource,
segmentIds)
+ .retrieveSegmentsById(datasource,
segmentIds, centralizedDatasourceSchemaConfig.isEnabled())
.stream()
.map(DataSegmentPlus::getDataSegment)
+ .map(v -> new DataSegmentWithSchemaInformation(v, null, null))
Review Comment:
Thanks for pointing it out. It is a bug, probably got introduced while
merging with master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
