AmatyaAvadhanula commented on code in PR #16162:
URL: https://github.com/apache/druid/pull/16162#discussion_r1531559028
##########
server/src/test/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriverFailTest.java:
##########
@@ -221,10 +221,8 @@ public void testFailDuringDrop() throws IOException,
InterruptedException, Timeo
Assert.assertNull(driver.startJob(null));
- for (int i = 0; i < ROWS.size(); i++) {
- committerSupplier.setMetadata(i + 1);
- Assert.assertTrue(driver.add(ROWS.get(i), "dummy", committerSupplier,
false, true).isOk());
- }
+ committerSupplier.setMetadata(1);
Review Comment:
This change is intentional to avoid any uncertainty that may arise due to
the order of segment ids.
By adding a single row, exactly one segment is created and we can verify its
id in the exception message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
