clintropolis commented on code in PR #16039:
URL: https://github.com/apache/druid/pull/16039#discussion_r1533179974
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/ArrayOverlapOperatorConversion.java:
##########
@@ -127,7 +130,7 @@ public DimFilter toDruidFilter(
// to create an empty array with no argument, we just return null.
return null;
} else if (arrayElements.length == 1) {
- if (plannerContext.isUseBoundsAndSelectors()) {
+ if (plannerContext.isUseBoundsAndSelectors() ||
(!simpleExtractionExpr.isDirectColumnAccess() && virtualColumnRegistry ==
null)) {
Review Comment:
it looks like it can be null in some join cases,
https://github.com/apache/druid/blob/master/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidJoinQueryRel.java#L497
calls it with null. will add a guard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
