clintropolis commented on code in PR #16039:
URL: https://github.com/apache/druid/pull/16039#discussion_r1534864286
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/ArrayOverlapOperatorConversion.java:
##########
@@ -127,7 +130,7 @@ public DimFilter toDruidFilter(
// to create an empty array with no argument, we just return null.
return null;
} else if (arrayElements.length == 1) {
- if (plannerContext.isUseBoundsAndSelectors()) {
+ if (plannerContext.isUseBoundsAndSelectors() ||
(!simpleExtractionExpr.isDirectColumnAccess() && virtualColumnRegistry ==
null)) {
Review Comment:
ok, reworked this a bit, if the virtual column registry is null it seems
equivalent to just use an expression filter rather than forcing a selector
filter + extractionFn, so I did that for now, since it seems better to do that
and get away from reliance on using extractionFn defined on filters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
