gargvishesh commented on PR #15965: URL: https://github.com/apache/druid/pull/15965#issuecomment-2014380106
> Would it be better to extract the `dataSchema`, `indexSpec`, `granularitySpec` and (compute) the `partitionsSpec`, and use a common utility for both native batch and MSQ? The bulk of the code is to extract/compute these values themselves, so I think the common utility will be of little value other than just creating the CompactionState object and the transform fn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org