kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535261509
########## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ########## @@ -152,6 +157,8 @@ public class TaskQueue private final AtomicInteger statusUpdatesInQueue = new AtomicInteger(); private final AtomicInteger handledStatusUpdates = new AtomicInteger(); + private final ObjectMapper jsonMapper; Review Comment: Also, the `ObjectMapper` should be injected into `TaskMaster` and then passed on to `TaskQueue` where it would be copied with the required mixins (the same way as is done in `SQLMetadataStorageActionHandler`). We should not create a `new JsonMapper()` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
