zachjsh commented on code in PR #16216:
URL: https://github.com/apache/druid/pull/16216#discussion_r1544696799
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/sql/ThetaSketchEstimateWithErrorBoundsOperatorConversion.java:
##########
@@ -46,7 +46,8 @@ public class
ThetaSketchEstimateWithErrorBoundsOperatorConversion implements Sql
private static final SqlFunction SQL_FUNCTION = OperatorConversions
.operatorBuilder(StringUtils.toUpperCase(FUNCTION_NAME))
.operandTypes(SqlTypeFamily.ANY, SqlTypeFamily.INTEGER)
- .returnTypeNonNull(SqlTypeName.OTHER)
+ .returnTypeInference(
+
OperatorConversions.complexReturnTypeWithNullability(SketchModule.BUILD_TYPE,
false))
Review Comment:
Thanks fixed, and think I got all the formatting ones, let me know if I
missed any.
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/quantiles/sql/DoublesSketchObjectSqlAggregator.java:
##########
@@ -52,7 +52,8 @@ public class DoublesSketchObjectSqlAggregator implements
SqlAggregator
OperatorConversions.aggregatorBuilder(NAME)
.operandNames("column", "k")
.operandTypes(SqlTypeFamily.ANY,
SqlTypeFamily.EXACT_NUMERIC)
- .returnTypeNonNull(SqlTypeName.OTHER)
+ .returnTypeInference(
+
OperatorConversions.complexReturnTypeWithNullability(HllSketchModule.TYPE,
false))
Review Comment:
thanks, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
