kfaraz commented on code in PR #16217:
URL: https://github.com/apache/druid/pull/16217#discussion_r1545933086


##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/AbstractParallelIndexSupervisorTaskTest.java:
##########
@@ -546,12 +548,17 @@ public ListenableFuture<Void> runTask(String taskId, 
Object taskObject)
 
     @Override
     public ListenableFuture<Map<String, Object>> taskReportAsMap(String taskId)
+    {
+      return Futures.immediateFuture(null);

Review Comment:
   It was doing that originally but not needed right now as I have added the 
other method `getLiveReportsForTask()` just below this one.
   
   This is anyway used only in the tests and I plan to fix it back up once I 
replace the `Map<String, Object>` in the `OverlordClient` with 
`TaskReport.ReportMap`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to