kfaraz commented on PR #16227: URL: https://github.com/apache/druid/pull/16227#issuecomment-2032258149
I don't think it is desirable to fall back to another API within the OverlordClientImpl. The OverlordClient methods are meant to have 1-to-1 correspondence with the Overlord APIs. Also, it is used in several places and some callers might actually want the result of the API itself even if the location turns out to be empty. It would make more sense to have the fallback logic in the specific task service locator class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
