github-advanced-security[bot] commented on code in PR #16208:
URL: https://github.com/apache/druid/pull/16208#discussion_r1548848130
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -2415,25 +2410,24 @@
startMetadataMatchesExisting =
startMetadata.asStartMetadata().matches(oldCommitMetadataFromDb.asStartMetadata());
}
- if (startMetadataGreaterThanExisting == 1 &&
!startMetadataMatchesExisting) {
- // Offset stored in StartMetadata is Greater than the last commited
metadata,
- // Then retry multiple task might be trying to publish the segment for
same partitions.
- log.info("Failed to update the metadata Store. The new start metadata:
[%s] is ahead of last commited end state: [%s].",
- startMetadata,
- oldCommitMetadataFromDb);
+ if (startMetadataGreaterThanExisting && !startMetadataMatchesExisting) {
+ // Offsets stored in startMetadata is greater than the last commited
metadata.
+ log.info(
+ "The new start metadata state[%s] is ahead of the last commited"
+ + " end state[%s]. Try resetting the supervisor.", startMetadata,
oldCommitMetadataFromDb
+ );
return new DataStoreMetadataUpdateResult(true, false,
- "Failed to update the metadata Store. The new start metadata is
ahead of last commited end state."
+ "The new start metadata state[%s] is ahead of the last commited"
+ + " end state[%s]. Try resetting the supervisor.", startMetadata,
oldCommitMetadataBytesFromDb
Review Comment:
## Implicit conversion from array to string
Implicit conversion from Array to String.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7204)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
