kgyrtkirk commented on code in PR #16231: URL: https://github.com/apache/druid/pull/16231#discussion_r1549445767
########## processing/src/main/java/org/apache/druid/query/rowsandcols/semantic/DefaultFramedOnHeapAggregatable.java: ########## @@ -187,7 +187,7 @@ public AggInterval next() groupToRowIndex(relativeGroupId(1)) ), Interval.of( - groupToRowIndex(relativeGroupId(-lowerOffset)), + groupToRowIndex(relativeGroupId(lowerOffset < 0 ? lowerOffset : -lowerOffset)), Review Comment: this doesn't look right - this is effectively: `-Math.abs(lowerOffset)` this part was already working with relative offsets ; so I think it should be simply `relativeGroupId(lowerOffset)` - didn't that worked? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org