adarshsanjeev commented on code in PR #16175:
URL: https://github.com/apache/druid/pull/16175#discussion_r1553110171
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -2057,25 +2071,25 @@ private static List<String> computeShardColumns(
// DimensionRangeShardSpec only handles ascending order.
if (column.order() != KeyOrder.ASCENDING) {
- return Collections.emptyList();
+ return Pair.of(Collections.emptyList(), "Cannot use RangeShardSpec,
RangedShardSpec only supports ascending CLUSTER BY keys. Using
NumberedShardSpec instead.");
}
ColumnType columnType =
signature.getColumnType(column.columnName()).orElse(null);
// DimensionRangeShardSpec only handles strings.
if (!(ColumnType.STRING.equals(columnType))) {
- return Collections.emptyList();
+ return Pair.of(Collections.emptyList(), "Cannot use RangeShardSpec,
RangedShardSpec only supports string CLUSTER BY keys. Using NumberedShardSpec
instead.");
}
// DimensionRangeShardSpec only handles columns that appear as-is in the
output.
if (outputColumns.isEmpty()) {
- return Collections.emptyList();
+ return Pair.of(Collections.emptyList(), "Cannot use RangeShardSpec,
RangeShardSpec only supports columns that appear as-is in the output. Using
NumberedShardSpec instead.");
Review Comment:
Changed the message to "Could not find output column name for column [%s]"
to include the column name. I'm not sure what conditions would cause the output
column to not be found here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
