kgyrtkirk commented on code in PR #16246: URL: https://github.com/apache/druid/pull/16246#discussion_r1556088587
########## rewrite.yml: ########## @@ -16,6 +16,8 @@ type: specs.openrewrite.org/v1beta/recipe name: org.apache.druid.RewriteRules recipeList: + - org.openrewrite.apache.commons.math.UpgradeApacheCommonsMath_2_3 + - org.openrewrite.apache.commons.collections.UpgradeApacheCommonsCollections_3_4 Review Comment: I don't see common-collections 3 being used at all - but it was pulled in into the project: * opencsv 5.8 -> commons-beanutils:1.9.4 -> commons-collections:3.2.2 * kafka_test -> commons-validator:commons-validator:jar:1.7:test -> commons-collections:3.2.2 it seems to me that there are only 2 classes being used from commons-collection4 ########## rewrite.yml: ########## @@ -16,6 +16,8 @@ type: specs.openrewrite.org/v1beta/recipe name: org.apache.druid.RewriteRules recipeList: + - org.openrewrite.apache.commons.math.UpgradeApacheCommonsMath_2_3 Review Comment: it seems to me that there were no usages of commons-math 2 inside the project; and it seems to me that the math2 library is not even loaded as a dependency I wonder in the above case why would we need the upgrade recipes for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
