AmatyaAvadhanula commented on code in PR #16258:
URL: https://github.com/apache/druid/pull/16258#discussion_r1559132319
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -743,7 +743,8 @@ public void onFailure(Throwable t)
}
if (System.currentTimeMillis() > nextCheckpointTime) {
- sequenceToCheckpoint = getLastSequenceMetadata();
Review Comment:
Can sequenceToCheckpoint be non-null before this point?
If yes, perhaps you could add the `isCheckpointed` condition to the if
condition, rather than changing the body in the if block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
