LakshSingla commented on PR #15420: URL: https://github.com/apache/druid/pull/15420#issuecomment-2047121929
@gianm Thanks for taking another look. I have addressed the review comments. Regarding the relevance and the use case of the `willMergeRunner`, I have reworded the docs. LMK in case they are still cryptic. The idea is to signify the `mergeResults` that the runner being called with it will be the `GroupByMergingQueryRunner` so that it can allocate the resources for that (hence the name "willMergeRunners", since it is not limited to the groupBy tool chest). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
