kfaraz commented on code in PR #16226:
URL: https://github.com/apache/druid/pull/16226#discussion_r1563931733
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java:
##########
@@ -361,22 +364,42 @@ public static MSQStagesReport.Stage
getFinalStage(MSQTaskReportPayload msqTaskRe
return null;
}
- public static Map<String, Object> getQueryExceptionDetails(Map<String,
Object> payload)
+ @Nullable
+ private static MSQErrorReport getQueryExceptionDetails(MSQTaskReportPayload
payload)
{
- return getMap(getMap(payload, "status"), "errorReport");
+ return payload == null ? null : payload.getStatus().getErrorReport();
}
- public static Map<String, Object> getMap(Map<String, Object> map, String key)
+ @Nullable
+ public static MSQTaskReportPayload getPayload(TaskReport.ReportMap reportMap)
{
- if (map == null) {
+ if (reportMap == null) {
return null;
}
- return (Map<String, Object>) map.get(key);
+
+ com.google.common.base.Optional<MSQTaskReport> report =
reportMap.findReport("multiStageQuery");
Review Comment:
Fixed.
##########
server/src/test/java/org/apache/druid/client/indexing/NoopOverlordClient.java:
##########
@@ -84,7 +85,7 @@ public ListenableFuture<TaskPayloadResponse>
taskPayload(String taskId)
}
@Override
- public ListenableFuture<Map<String, Object>> taskReportAsMap(String taskId)
+ public ListenableFuture<TaskReport.ReportMap> taskReportAsMap(String taskId)
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
