LakshSingla commented on code in PR #16230:
URL: https://github.com/apache/druid/pull/16230#discussion_r1567089431
##########
processing/src/test/java/org/apache/druid/query/aggregation/firstlast/last/StringLastVectorAggregatorTest.java:
##########
@@ -418,12 +419,12 @@ public void aggregateBatchWithRows()
for (int i = 0; i < positions.length; i++) {
Pair<Long, String> result = (Pair<Long, String>) target.get(buf,
positions[i] + positionOffset);
Assert.assertEquals(times[rows[i]], result.lhs.longValue());
- Assert.assertEquals(VALUES[rows[i]], result.rhs);
+ Assert.assertEquals(NullHandling.nullToEmptyIfNeeded(VALUES[rows[i]]),
result.rhs);
Review Comment:
Kind of, but not exactly. In the default value mode, the aggregator will now
return the default value instead of null. Technically, this is the correct
behavior (as opposed to the original behavior), however, in practice, the
upstream callers will coerce null to the default value anyway, therefore it
won't matter if null is returned by the aggregator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
