kfaraz commented on code in PR #16281:
URL: https://github.com/apache/druid/pull/16281#discussion_r1567298099
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java:
##########
@@ -909,24 +909,9 @@ public CommandListBuilder add(String arg)
return this;
}
- public CommandListBuilder addSystemProperty(String property, int value)
+ public CommandListBuilder addSystemProperty(String property, Object value)
Review Comment:
Yeah, that would be nice 👍🏻 . The value returned by `task.getContextValue()`
would most likely not be null but best add a null check too before invoking the
`.toString()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
