kfaraz opened a new pull request, #16309:
URL: https://github.com/apache/druid/pull/16309
### Description
Task action audit logging was first deprecated and disabled by default in
Druid 0.13, #6368.
As called out in the original discussion #5859, there are several drawbacks
to persisting task action audit logs.
- Only usage of these audit logs is to serve the API
`/indexer/v1/task/{taskId}/segments`
which returns the list of segments created by a task.
- The use case is really narrow and no prod clusters really use this
information.
- There can be better ways of obtaining this information, such as
metrics (`segment/added/bytes`) and task reports.
- A task persisting several segments would bloat up the audit logs table
putting unnecessary strain
on metadata storage.
- It was only being used by `SegmentInsertAction`?
### Changes
- Remove `TaskAuditLogConfig`
- Remove method `TaskAction.isAudited()`. No task action is audited anymore.
- Remove `SegmentInsertAction` as it is not used anymore.
`SegmentTransactionalInsertAction` is the new incarnation which has been in use
for a while.
-
### Release notes
- Task action audit logging was deprecated in Druid 0.13 and is being
completely removed in this release.
- The API `/indexer/v1/task/{taskId}/segments` is not supported anymore and
will give a 404 NOT FOUND response.
- Druid will not write to or read from the metadata table `druid_taskLog`
anymore.
- The property `indexer.tasklog` will be ignored by Druid.
### Extension dev notes
The changes here do not break any metadata storage extension.
### Rolling upgrade concerns
No upgrade concerns as none of the tasks use the `SegmentInsertAction`.
### Future solutions
In the future, if we feel the need to fetch the list of segments that was
created by a certain task or task group,
a more preferable approach would be to simply add a task_id column in the
segments table.
Something similar has been recently done for pending segments in #16144.
Alternatively, it could also be possible to determine the list of segments
committed by a task by inspecting
the reports of the task or emitted metrics.
### Release note
### Key changed/added classes in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
