findingrish commented on code in PR #15817:
URL: https://github.com/apache/druid/pull/15817#discussion_r1576123911
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -330,11 +330,13 @@ SegmentPublishResult commitSegmentsAndMetadata(
* @param appendSegmentToReplaceLock Map from append segment to the currently
* active REPLACE lock (if any) covering it
* @param taskAllocatorId allocator id of the task committing the
segments to be appended
+ * @param segmentSchemaMapping schema of append segments
*/
SegmentPublishResult commitAppendSegments(
Set<DataSegment> appendSegments,
Map<DataSegment, ReplaceTaskLock> appendSegmentToReplaceLock,
- @Nullable MinimalSegmentSchemas minimalSegmentSchemas
+ String taskAllocatorId,
Review Comment:
It is there in the master
https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java#L498.
It seems you are looking at a subset of commits from PR, check this diff
https://github.com/apache/druid/pull/15817/files#diff-519b0b98ee6a12cbb850f2f27fb6947e86e9353c79373ccb8d78d6113d1304b5R551.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
