kgyrtkirk commented on code in PR #16249:
URL: https://github.com/apache/druid/pull/16249#discussion_r1576292245
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -570,6 +570,7 @@ private SqlTestFramework(Builder builder)
// test pulls in a module, then pull in that module, even though we are
// not the Druid node to which the module is scoped.
.ignoreLoadScopes()
+ .addModule(binder ->
binder.bind(Closer.class).toInstance(resourceCloser))
Review Comment:
we've talked about this offline - to fix this by properly closing the object
where it was created (this is the current version).
the `LifecycleManaged` is not yet used around here - but it would be much
better to rely on that; I'll probably do that in a later changeset - if the
need to cleanup configurations will be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
