AmatyaAvadhanula commented on code in PR #16162:
URL: https://github.com/apache/druid/pull/16162#discussion_r1577565540
##########
server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java:
##########
@@ -898,7 +898,7 @@ private static int computeNumChangedSegments(List<String>
segmentIds, int[] segm
*
* @implNote JDBI 3.x has better support for binding {@code IN} clauses
directly.
*/
- private static String getParameterizedInConditionForColumn(final String
columnName, final List<String> values)
+ public static String getParameterizedInConditionForColumn(final String
columnName, final List<String> values)
Review Comment:
Made it package private
##########
server/src/main/java/org/apache/druid/indexing/overlord/SegmentPublishResult.java:
##########
@@ -92,6 +118,12 @@ public String getErrorMsg()
return errorMsg;
}
+ @JsonIgnore
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
