zachjsh commented on code in PR #16260:
URL: https://github.com/apache/druid/pull/16260#discussion_r1580019321
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:
##########
@@ -281,6 +286,37 @@ public void validateInsert(final SqlInsert insert)
}
}
+ @Override
+ protected SelectNamespace createSelectNamespace(
+ SqlSelect select,
+ SqlNode enclosingNode)
+ {
+ if (enclosingNode instanceof DruidSqlIngest) {
+ // The target is a new or existing datasource.
+ // The target namespace is both the target table ID and the row type for
that table.
+ final SqlValidatorNamespace targetNamespace = Objects.requireNonNull(
+ getNamespace(enclosingNode),
+ () -> "namespace for " + enclosingNode
+ );
+ final IdentifierNamespace insertNs = (IdentifierNamespace)
targetNamespace;
+ SqlIdentifier identifier = insertNs.getId();
+ SqlValidatorTable catalogTable =
getCatalogReader().getTable(identifier.names);
+ if (catalogTable != null) {
Review Comment:
if the ingestNode already has the clustering columns, they will be used.
There are existing tests which test that the clustering columns are used in the
plan returned from dml query, when clustering is defined at query time, and the
table is / it not in catalog. Let me know if this covers the issue that think
could occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
