AmatyaAvadhanula commented on code in PR #16321:
URL: https://github.com/apache/druid/pull/16321#discussion_r1580486299
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -630,6 +630,7 @@ public void run()
stillReading = !assignment.isEmpty();
SequenceMetadata<PartitionIdType, SequenceOffsetType>
sequenceToCheckpoint = null;
+ boolean flagForLogLine = true;
Review Comment:
This is a very vague name.
Also if the goal is to log the segment row and total row values only once
when a push is required, you could alternatively store
`AppenderatorDriverAddResult pushTriggeringAddResult = null;` outside the loop
which is set along with `sequenceToCheckPoint` and you could log the result
outside the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
