abhishekrb19 commented on code in PR #16343:
URL: https://github.com/apache/druid/pull/16343#discussion_r1582434479
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java:
##########
@@ -94,10 +94,10 @@
public class HadoopIndexTask extends HadoopTask implements ChatHandler
{
+ public static final String TYPE = "index_hadoop";
Review Comment:
Same here regarding `getType()` using `TYPE`.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/NoopTask.java:
##########
@@ -41,6 +41,7 @@
*/
public class NoopTask extends AbstractTask implements
PendingSegmentAllocatingTask
{
+ public static final String TYPE = "noop";
Review Comment:
We can also change `getType()` to return `TYPE` instead of the hardcoded
value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
