LakshSingla commented on code in PR #16342:
URL: https://github.com/apache/druid/pull/16342#discussion_r1584136923
##########
docs/operations/metrics.md:
##########
@@ -61,6 +61,7 @@ Most metric values reset each emission period, as specified
in `druid.monitoring
|`query/success/count`|Number of queries successfully processed.|This metric
is only available if the `QueryCountStatsMonitor` module is included.| |
|`query/failed/count`|Number of failed queries.|This metric is only available
if the `QueryCountStatsMonitor` module is included.| |
|`query/interrupted/count`|Number of queries interrupted due to
cancellation.|This metric is only available if the `QueryCountStatsMonitor`
module is included.| |
+|`query/merge/buffersUsed`|number of merge buffers allocated to broker while
performing groupBy merge queries.|This metric is only available if the
`QueryCountStatsMonitor` module is included.| |
Review Comment:
This shouldn't be "allocated to broker". As per my perception, allocated to
the broker means the total number of merge buffers present there. Also, there
is no such thing as "groupBy merge query".
```suggestion
|`query/merge/buffersUsed`|Number of merge buffers used up to merge the
results of group by queries.|This metric is only available if the
`QueryCountStatsMonitor` module is included.| |
```
##########
processing/src/test/java/org/apache/druid/query/TestBufferPool.java:
##########
@@ -147,4 +147,10 @@ public Collection<RuntimeException>
getOutstandingExceptionsCreated()
{
return takenFromMap.values();
}
+
+ @Override
+ public int getUsedBufferCount()
+ {
+ return Integer.MAX_VALUE;
+ }
Review Comment:
We can probably have the correct implementation for this class, even if it
is a test utility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
