vtlim commented on code in PR #15659:
URL: https://github.com/apache/druid/pull/15659#discussion_r1587995765
##########
docs/development/extensions-contrib/prometheus.md:
##########
@@ -104,6 +108,41 @@ For example:
}
```
+#### Histogram
+Prometheus histogram with configurable bucket sizes.
+```json
+<druid metric name> : {
+ "dimensions" : <dimension list>,
+ "type" : "histogram",
+ "buckets": <bucket list>
+ "help" : <help text>
+}
+```
+
+#### Count and Gauge
+Prometheus counters and gauges
+```json
+<druid metric name> : {
+ "dimensions" : <dimension list>,
+ "type" : <count|gauge>,
+ "help" : <help text>
+}
+```
+
+#### Summary
+Prometheus summary with configurable, quantiles, errors and age buckets.
Review Comment:
```suggestion
Generate a Prometheus summary with configurable quantiles, errors, and age
buckets.
```
##########
docs/development/extensions-contrib/prometheus.md:
##########
@@ -77,18 +77,22 @@ All metric names and labels are reformatted to match
Prometheus standards.
### Metric mapping
-Each metric to be collected by Prometheus must specify a type, one of `[timer,
counter, guage]`. Prometheus Emitter expects this mapping to
-be provided as a JSON file. Additionally, this mapping specifies which
dimensions should be included for each metric. Prometheus expects
-histogram timers to use Seconds as the base unit. Timers which do not use
seconds as a base unit can use the `conversionFactor` to set
-the base time unit. If the user does not specify their own JSON file, a
default mapping is used. All
-metrics are expected to be mapped. Metrics which are not mapped will not be
tracked.
+Each metric to be collected by Prometheus must specify a type, one of `[timer,
count, guage, histogram, summary]`.
+Prometheus Emitter expects this mapping to be provided as a JSON file.
Additionally, this mapping specifies which dimensions should be included for
each metric.
+Prometheus expects histogram timers to use Seconds as the base unit. Timers
which do not use seconds as a base unit can use the `conversionFactor` to set
Review Comment:
```suggestion
The Prometheus emitter expects this mapping to be provided as a JSON file.
Additionally, this mapping specifies which dimensions should be included for
each metric.
Prometheus expects histogram timers to use seconds as the base unit. Timers
which do not use seconds as a base unit can use the `conversionFactor` to set
```
##########
docs/development/extensions-contrib/prometheus.md:
##########
@@ -77,18 +77,22 @@ All metric names and labels are reformatted to match
Prometheus standards.
### Metric mapping
-Each metric to be collected by Prometheus must specify a type, one of `[timer,
counter, guage]`. Prometheus Emitter expects this mapping to
-be provided as a JSON file. Additionally, this mapping specifies which
dimensions should be included for each metric. Prometheus expects
-histogram timers to use Seconds as the base unit. Timers which do not use
seconds as a base unit can use the `conversionFactor` to set
-the base time unit. If the user does not specify their own JSON file, a
default mapping is used. All
-metrics are expected to be mapped. Metrics which are not mapped will not be
tracked.
+Each metric to be collected by Prometheus must specify a type, one of `[timer,
count, guage, histogram, summary]`.
Review Comment:
```suggestion
Each metric to be collected by Prometheus must specify a type, one of
`[timer, histogram, count, gauge, summary]`.
```
Suggest matching ordering with the sections below
##########
docs/development/extensions-contrib/prometheus.md:
##########
@@ -104,6 +108,41 @@ For example:
}
```
+#### Histogram
+Prometheus histogram with configurable bucket sizes.
Review Comment:
```suggestion
Generate a Prometheus histogram with configurable bucket sizes.
```
##########
docs/development/extensions-contrib/prometheus.md:
##########
@@ -104,6 +108,41 @@ For example:
}
```
+#### Histogram
+Prometheus histogram with configurable bucket sizes.
+```json
+<druid metric name> : {
+ "dimensions" : <dimension list>,
+ "type" : "histogram",
+ "buckets": <bucket list>
+ "help" : <help text>
+}
+```
+
+#### Count and Gauge
+Prometheus counters and gauges
Review Comment:
```suggestion
Generate a Prometheus counter or gauge.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
