vtlim commented on code in PR #15926: URL: https://github.com/apache/druid/pull/15926#discussion_r1588006525
########## docs/querying/sql-functions.md: ########## @@ -860,6 +860,13 @@ Extracts an `ARRAY<COMPLEX<json>>` value from `expr` at the specified `path`. If Extracts a literal value from `expr` at the specified `path`. If you specify `RETURNING` and an SQL type name (such as `VARCHAR`, `BIGINT`, `DOUBLE`, etc) the function plans the query using the suggested type. Otherwise, it attempts to infer the type based on the context. If it can't infer the type, it defaults to `VARCHAR`. +## JSON_MERGE + +**Function type:** [JSON](sql-json-functions.md) + +`json_merge(expr1, expr2[, expr3 ...])` Review Comment: ```suggestion `JSON_MERGE(expr1, expr2[, expr3 ...])` ``` ########## docs/querying/math-expr.md: ########## @@ -245,6 +245,7 @@ JSON functions provide facilities to extract, transform, and create `COMPLEX<jso | to_json_string(expr) | Convert `expr` into a JSON `STRING` value | | json_keys(expr, path) | Get array of field names from `expr` at the specified JSONPath `path`, or null if the data does not exist or have any fields | | json_paths(expr) | Get array of all JSONPath paths available from `expr` | +| json_merge(expr1, expr2[, expr3 ...]) | Merges two or more JSON `STRING` or `COMPLEX<json>` into one. Right-most being preserved on key overlaps | Review Comment: ```suggestion | json_merge(expr1, expr2[, expr3 ...]) | Merges two or more JSON `STRING` or `COMPLEX<json>` into one. Preserves the rightmost value when there are key overlaps. | ``` ########## docs/querying/sql-functions.md: ########## @@ -860,6 +860,13 @@ Extracts an `ARRAY<COMPLEX<json>>` value from `expr` at the specified `path`. If Extracts a literal value from `expr` at the specified `path`. If you specify `RETURNING` and an SQL type name (such as `VARCHAR`, `BIGINT`, `DOUBLE`, etc) the function plans the query using the suggested type. Otherwise, it attempts to infer the type based on the context. If it can't infer the type, it defaults to `VARCHAR`. +## JSON_MERGE Review Comment: Include this in alphabetical order between JSON_KEYS and JSON_PATHS ########## docs/querying/sql-functions.md: ########## @@ -860,6 +860,13 @@ Extracts an `ARRAY<COMPLEX<json>>` value from `expr` at the specified `path`. If Extracts a literal value from `expr` at the specified `path`. If you specify `RETURNING` and an SQL type name (such as `VARCHAR`, `BIGINT`, `DOUBLE`, etc) the function plans the query using the suggested type. Otherwise, it attempts to infer the type based on the context. If it can't infer the type, it defaults to `VARCHAR`. +## JSON_MERGE + +**Function type:** [JSON](sql-json-functions.md) Review Comment: Add this function to the SQL functions doc too (sql-json-functions.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
