AmatyaAvadhanula commented on code in PR #16380:
URL: https://github.com/apache/druid/pull/16380#discussion_r1588804613


##########
server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java:
##########
@@ -3192,4 +3192,59 @@ public void testTimelineWith1CorePartitionTombstone() 
throws IOException
     SegmentTimeline segmentTimeline = 
SegmentTimeline.forSegments(allUsedSegments);
     Assert.assertEquals(0, segmentTimeline.lookup(interval).size());
   }
+
+  @Test
+  public void testSegmentIdMustNotBeReused() throws IOException

Review Comment:
   Done.
   Did not rename the method however since the version is not necessarily 
unused. It can occur if any unused or used segment conflicts with an allocated 
pending segment id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to