amankothari04 commented on PR #12559:
URL: https://github.com/apache/druid/pull/12559#issuecomment-2099786874
@a2l007
I see
`this.durationToRetain == null ||
this.durationToRetain.compareTo(Duration.standardDays(1)) >= 0,
"request logs retention period must be atleast P1D"`
Shouldnt it be
`this.durationToRetain.compareTo(Duration.standardDays(1)) <= 0` ?
We want durationToRetain to be more than a day right? Then why throw
error-comment when its more than a day?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]