Akshat-Jain commented on code in PR #16358:
URL: https://github.com/apache/druid/pull/16358#discussion_r1594908529
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestBase.java:
##########
@@ -807,12 +809,34 @@ private MSQErrorReport getErrorReportOrThrow(String
controllerTaskId)
private void assertMSQSpec(MSQSpec expectedMSQSpec, MSQSpec querySpecForTask)
{
- Assert.assertEquals(expectedMSQSpec.getQuery(),
querySpecForTask.getQuery());
+ assertMSQSpecQuery(expectedMSQSpec.getQuery(),
querySpecForTask.getQuery());
Assert.assertEquals(expectedMSQSpec.getAssignmentStrategy(),
querySpecForTask.getAssignmentStrategy());
Assert.assertEquals(expectedMSQSpec.getColumnMappings(),
querySpecForTask.getColumnMappings());
Assert.assertEquals(expectedMSQSpec.getDestination(),
querySpecForTask.getDestination());
}
+ private void assertMSQSpecQuery(Query msqSpecQuery, Query taskSpecQuery)
+ {
+ Assert.assertEquals(msqSpecQuery.getId(), taskSpecQuery.getId());
Review Comment:
@kfaraz Actually no, you're right. This seems an older code change which was
needed when we were putting things in the queryContext. This shouldn't be
needed anymore, I've reverted this change and am running the MSQ tests locally
to double check.
Thanks for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
