AmatyaAvadhanula commented on PR #16393:
URL: https://github.com/apache/druid/pull/16393#issuecomment-2102091000
The transactional append and replace actions are safeguarded by the giant
lock in TaskLockbox
```
/**
* Perform the given action with a guarantee that the locks of the task
are not revoked in the middle of action. This
* method first checks that all locks for the given task and intervals are
valid and perform the right action.
* <p>
* The given action should be finished as soon as possible because all
other methods in this class are blocked until
* this method is finished.
*
* @param task task performing a critical action
* @param intervals intervals
* @param action action to be performed inside of the critical section
*/
public <T> T doInCriticalSection(Task task, Set<Interval> intervals,
CriticalAction<T> action) throws Exception
{
giant.lock();
try {
return action.perform(isTaskLocksValid(task, intervals));
}
finally {
giant.unlock();
}
}
```
Closing this PR as the checks added are no longer necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
