kfaraz opened a new pull request, #16423:
URL: https://github.com/apache/druid/pull/16423
### Description
The current model of tracking task counts for the `TaskCountStatsMonitor` is
too limiting and verbose.
- It requires a different method for each type of task count - running,
waiting, pending, etc.
- It makes adding new dimensions and metrics cumbersome as can be seen in
the PR #16403
### Changes
- Remove deprecated methods from `TaskCountStatsProvider`
- Simplify collection of stats in `TaskQueue`.
- Remove methods `getRunningTaskCount`, `getWaitingTaskCount`, etc.
- Collect all stats in a single `CoordinatorRunStats` instance which is
reset upon invocation of `getQueueStats()`
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
