kfaraz commented on code in PR #16420:
URL: https://github.com/apache/druid/pull/16420#discussion_r1595341930
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/ClientCompactionTaskQuerySerdeTest.java:
##########
@@ -82,6 +84,7 @@ public class ClientCompactionTaskQuerySerdeTest
@Test
public void testClientCompactionTaskQueryToCompactionTask() throws
IOException
{
+ Map<String, Object> context = ImmutableMap.of("key", "value");
Review Comment:
```suggestion
final Map<String, Object> context = ImmutableMap.of("key", "value");
```
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/ClientCompactionTaskQuerySerdeTest.java:
##########
@@ -233,6 +235,11 @@ public void
testClientCompactionTaskQueryToCompactionTask() throws IOException
query.getMetricsSpec(),
task.getMetricsSpec()
);
+
+ for (String key : context.keySet()) {
Review Comment:
```suggestion
// Verify values of context keys originally present in the
ClientCompactionTaskQuery
for (String key : context.keySet()) {
```
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/ClientCompactionTaskQuerySerdeTest.java:
##########
@@ -233,6 +235,11 @@ public void
testClientCompactionTaskQueryToCompactionTask() throws IOException
query.getMetricsSpec(),
task.getMetricsSpec()
);
+
+ for (String key : context.keySet()) {
+ Assert.assertEquals(context.get(key), task.getContext().get(key));
+ }
+ Assert.assertEquals(LookupLoadingSpec.Mode.NONE.toString(),
task.getContext().get(LookupLoadingSpec.CTX_LOOKUP_LOADING_MODE));
Review Comment:
```suggestion
// Verify values of context parameters added by the CompactionTask
Assert.assertEquals(LookupLoadingSpec.Mode.NONE.toString(),
task.getContext().get(LookupLoadingSpec.CTX_LOOKUP_LOADING_MODE));
```
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/ClientCompactionTaskQuerySerdeTest.java:
##########
@@ -351,7 +358,16 @@ public void
testCompactionTaskToClientCompactionTaskQuery() throws IOException
final byte[] json = mapper.writeValueAsBytes(task);
final ClientCompactionTaskQuery actual = (ClientCompactionTaskQuery)
mapper.readValue(json, ClientTaskQuery.class);
- Assert.assertEquals(expected, actual);
+ Assert.assertEquals(expected.getDataSource(), actual.getDataSource());
+ Assert.assertEquals(expected.getId(), actual.getId());
+ Assert.assertEquals(expected.getType(), actual.getType());
+ Assert.assertEquals(expected.getGranularitySpec(),
actual.getGranularitySpec());
+ Assert.assertEquals(expected.getDimensionsSpec(),
actual.getDimensionsSpec());
+ Assert.assertEquals(expected.getIoConfig(), actual.getIoConfig());
+ Assert.assertEquals(expected.getTransformSpec(),
actual.getTransformSpec());
+ Assert.assertArrayEquals(expected.getMetricsSpec(),
actual.getMetricsSpec());
+ Assert.assertEquals(expected.getTuningConfig(), actual.getTuningConfig());
Review Comment:
Why did we need to break this up? How can we retain the original equality
check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
