kgyrtkirk commented on code in PR #16402:
URL: https://github.com/apache/druid/pull/16402#discussion_r1595394896
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -12941,8 +12941,7 @@ public void
testRepeatedIdenticalVirtualExpressionGrouping()
.setVirtualColumns(expressionVirtualColumn("v0", "1",
ColumnType.LONG))
.setDimensions(
dimensions(
- new DefaultDimensionSpec("v0", "d0",
ColumnType.LONG),
- new DefaultDimensionSpec("v0", "d1",
ColumnType.LONG)
+ new DefaultDimensionSpec("v0", "d0",
ColumnType.LONG)
Review Comment:
I was looking at this for a while - but actually its ok; since the case is
reduced to `TRUE` because `dim1 = NULL` may never be `TRUE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
