abhishekrb19 commented on PR #16439: URL: https://github.com/apache/druid/pull/16439#issuecomment-2113012694
Thanks for the review, @kfaraz. After digging up a bit more, I see there are some more changes needed to make it work for tasks, where the task locations aren't used/injected correctly in `SegmentLoadDropHandler`. Also, yes, the docs for this configuration are stale: https://druid.apache.org/docs/latest/configuration/#storing-segments. >Just to double check, did you actually run into this issue or did you discover it while reading through the code? I ran into `IndexOutOfBoundsException` by accident when I didn't set the storage locations on the brokers, which should be optional. Marking this as draft until the other things are fleshed out and then I will rethink this approach to enforce the storage locations validation for historicals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
