arunramani commented on code in PR #16472:
URL: https://github.com/apache/druid/pull/16472#discussion_r1607338366
##########
processing/src/main/java/org/apache/druid/java/util/metrics/CgroupCpuMonitor.java:
##########
@@ -67,7 +71,16 @@ public boolean doMonitor(ServiceEmitter emitter)
"cgroup/cpu/cores_quota",
computeProcessorQuota(cpuSnapshot.getQuotaUs(),
cpuSnapshot.getPeriodUs())
));
+ emitter.emit(builder.setMetric("cgroup/cpuacct/usage",
cpuSnapshot.getUsageNs()));
Review Comment:
I think I messed up by not putting all of these metric names into a single
constant file `CgroupUtil`. In a subsequent PR, do you think you can do that
consolidation work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
