kgyrtkirk commented on code in PR #16534:
URL: https://github.com/apache/druid/pull/16534#discussion_r1624057255
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupingEngine.java:
##########
@@ -686,13 +686,27 @@ public Sequence<ResultRow> processSubtotalsSpec(
processingConfig.intermediateComputeSizeBytes()
);
- List<String> queryDimNames =
baseSubtotalQuery.getDimensions().stream().map(DimensionSpec::getOutputName)
+ List<String> queryDimNamesInOrder =
baseSubtotalQuery.getDimensions().stream().map(DimensionSpec::getOutputName)
Review Comment:
I think I understand the reasons/etc here - but if these are the column the
query's output will be ordered; can't we place these logics inside a member
method as `GroupByQuery#getOrderColumnNames` or something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
