kfaraz commented on code in PR #16521:
URL: https://github.com/apache/druid/pull/16521#discussion_r1624747297
##########
extensions-core/azure-extensions/src/test/java/org/apache/druid/data/input/azure/AzureInputSourceTest.java:
##########
@@ -364,29 +370,34 @@ public void test_systemFields()
(containerName, blobPath, storage) -> null
);
- Assert.assertEquals("azure://foo/bar",
azureInputSource.getSystemFieldValue(entity, SystemField.URI));
- Assert.assertEquals("foo", azureInputSource.getSystemFieldValue(entity,
SystemField.BUCKET));
- Assert.assertEquals("bar", azureInputSource.getSystemFieldValue(entity,
SystemField.PATH));
+ assertEquals("azure://foo/bar",
azureInputSource.getSystemFieldValue(entity, SystemField.URI));
+ assertEquals("foo", azureInputSource.getSystemFieldValue(entity,
SystemField.BUCKET));
+ assertEquals("bar", azureInputSource.getSystemFieldValue(entity,
SystemField.PATH));
}
@Test
public void abidesEqualsContract()
{
- EqualsVerifier.forClass(AzureInputSource.class)
- .usingGetClass()
- .withPrefabValues(Logger.class, new
Logger(AzureStorage.class), new Logger(AzureStorage.class))
- .withPrefabValues(BlobContainerClient.class, new
BlobContainerClientBuilder().buildClient(), new
BlobContainerClientBuilder().buildClient())
- .withPrefabValues(AzureStorage.class, new AzureStorage(null,
null), new AzureStorage(null, null))
- .withNonnullFields("storage")
- .withNonnullFields("entityFactory")
- .withNonnullFields("azureCloudBlobIterableFactory")
- .withNonnullFields("inputDataConfig")
- .withNonnullFields("objectGlob")
- .withNonnullFields("scheme")
- .verify();
+ EqualsVerifier
+ .forClass(AzureInputSource.class)
+ .usingGetClass()
+ .withPrefabValues(Logger.class, new Logger(AzureStorage.class), new
Logger(AzureStorage.class))
+ .withPrefabValues(
+ BlobContainerClient.class,
+ new BlobContainerClientBuilder().buildClient(),
+ new BlobContainerClientBuilder().buildClient()
+ )
+ .withPrefabValues(AzureStorage.class, new AzureStorage(null, null),
new AzureStorage(null, null))
+ .withNonnullFields("storage")
+ .withNonnullFields("entityFactory")
+ .withNonnullFields("azureCloudBlobIterableFactory")
+ .withNonnullFields("inputDataConfig")
+ .withNonnullFields("objectGlob")
+ .withNonnullFields("scheme")
+ .verify();
Review Comment:
Yes, since this is more of a personal preference, I think it can be reverted
as it doesn't really affect readability. Best to keep the diff small.
In this case, there is no style preferred by Druid as such. But in general,
I prefer to not include changes which do not improve upon the existing code in
any way. Since all devs have their own personal styles, it can sometimes cause
PRs to bloat up with unnecessary changes.
Hope that makes sense 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
