Akshat-Jain commented on code in PR #16481:
URL: https://github.com/apache/druid/pull/16481#discussion_r1627296496
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -269,52 +213,74 @@ public void close() throws IOException
// Closeables are closed in LIFO order
closer.register(() -> {
// This should be emitted as a metric
+ long totalChunkSize = (currentChunk.id - 1) * chunkSize +
currentChunk.length();
Review Comment:
It allows us to not have a Map<Chunk, Future> unnecessarily and helps the
rest of the code be cleaner and simpler, which I really liked. Can you please
elaborate more on why you'd prefer adding them individually? Thanks!
PS: Can the chunkSize change in the middle of the operation? (in case of
node failures or rolling upgrades where we update the chunk size or something
along those lines?) 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
